Draft
Conversation
jonas089
force-pushed
the
jonas/ofac2
branch
4 times, most recently
from
8b4f3cd to
8015926
Compare
…flict with git dep Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
This PR has been updated to work with the generalized denylist that will hopefully be merged into oif-solver: |
damiannolan
reviewed
Mar 17, 2026
| solver-settlement = { path = "../solver-settlement", optional = true } | ||
| solver-storage = { git = "https://github.com/celestiaorg/oif-solver", rev = "a06231ca236ee9ce156900cd2cc9915fbe847cdc", optional = true } | ||
| solver-types = { git = "https://github.com/celestiaorg/oif-solver", rev = "a06231ca236ee9ce156900cd2cc9915fbe847cdc", features = ["oif-interfaces"], optional = true } | ||
| solver-account = { git = "https://github.com/celestiaorg/oif-solver", branch = "jonas/denylist", optional = true } |
Collaborator
There was a problem hiding this comment.
Cool so we can possibly get rid of the fork completely after the upstream PR is merged?
Collaborator
Author
There was a problem hiding this comment.
Almost. I also had to add eden to the registry. Will create another PR for that once the current one is merged.
Collaborator
Author
There was a problem hiding this comment.
I converted this back to draft because we can't just depend on jonas/denylist. We should wait for the denylist to be merged and then add the eden testnet either to a branch that's rebased or submit a PR for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces: #31
It depends on https://github.com/celestiaorg/oif-solver/tree/jonas/fix-expose-api-server
and should be reviewed / merged AFTER #37